Setup Nextcloud 19.0.4 on Fedora 32

JaredBusch

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

What does the line do exactly?
Sets the DocumentRoot parameter to /var/www/html/nextcloud ?

Correct.

(      # Start a capture group
^      # Matches the start of the line 
DocumentRoot  # Matches the word I am want
\s     # a space character I should probably remove that. came from an example I found
*      # umm everything maybe? not sure inside the capture group also likely need removed
)      # End capture group 
.*     # Matches anything
$      # Matches the end of the line

So, sed should find any instance of DocumentRoot at the beging of a line. This happens only once in a default Apache config file.

The capture group means to capture the term within the parentheses in a variable. This is the 1 in the replacement section of the s/// command.

I am then appending "/var/www/html/nextcloud" to the captured string "DocumentRoot" to end up with his

JaredBusch

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

~~What does $WWW_PATH and $APP_FOLDER contain?~~
Ah, the first post says: /var/www/html and nextcloud

And that is why I want to use the environment variables. Not everyone installs everything to the default location.

JaredBusch

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

sudo sed -i -e 's/(^DocumentRoot\s*).*$/\1"/var/www/html/nextcloud"/' /etc/httpd/conf/httpd.conf

Better sed. I removed the \s*

1337

@JaredBusch said in Setup Nextcloud 19.0.4 on Fedora 32:

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

sudo sed -i -e 's/(^DocumentRoot\s*).*$/\1"/var/www/html/nextcloud"/' /etc/httpd/conf/httpd.conf

Better sed. I removed the \s*

I think you can simplify it way more.

you don't need -e
don't use the / separator, use for instance #. So s#expression#replacement#. Then you don't have to escape your paths. And then you can put your variables straight in.

1337

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

@JaredBusch said in Setup Nextcloud 19.0.4 on Fedora 32:

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

sudo sed -i -e 's/(^DocumentRoot\s*).*$/\1"/var/www/html/nextcloud"/' /etc/httpd/conf/httpd.conf

Better sed. I removed the \s*

I think you can simplify it way more.

you don't need -e

don't use the / separator, use for instance #. So s#expression#replacement#. Then you don't have to escape your paths. And then you can put your variables straight in.

Don't think you need the sed script inside a quoted string either.

Maybe something like this:

sudo sed -i s#\(^DocumentRoot\).*$#\1$WWW_PATH/$APP_FOLDER# /etc/httpd/conf/httpd.conf

If you want quotes around the sed "instructions" use " so you get variable expansion, and not '.
But you don't need to quote a string as long as it doesn't contain spaces.

JaredBusch

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

you don't need -e

You just trying to fix all my old habits?

JaredBusch

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

@JaredBusch said in Setup Nextcloud 19.0.4 on Fedora 32:

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

sudo sed -i -e 's/(^DocumentRoot\s*).*$/\1"/var/www/html/nextcloud"/' /etc/httpd/conf/httpd.conf

Better sed. I removed the \s*

I think you can simplify it way more.

you don't need -e

don't use the / separator, use for instance #. So s#expression#replacement#. Then you don't have to escape your paths. And then you can put your variables straight in.

Don't think you need the sed script inside a quoted string either.

Maybe something like this:
sudo sed -i s#$^DocumentRoot$.*$#\1$WWW_PATH/$APP_FOLDER# /etc/httpd/conf/httpd.conf
If you want quotes around the sed "instructions" use " so you get variable expansion, and not '.
But you don't need to quote a string as long as it doesn't contain spaces.

I'll try it in a bit on my local test instance.

I'm in the middle of migrating the CentOS 7 system to the Fedora 32 system that caused me to write this in the first place.

JaredBusch

Could not make it execute without the quotes
But this works.

sudo sed -i 's#\(^DocumentRoot\).*$#\1 "'"$WWW_PATH"'/'"$APP_FOLDER"'"#' /etc/httpd/conf/httpd.conf

1337

@JaredBusch said in Setup Nextcloud 19.0.4 on Fedora 32:

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:
@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

@JaredBusch said in Setup Nextcloud 19.0.4 on Fedora 32:

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

sudo sed -i -e 's/(^DocumentRoot\s*).*$/\1"/var/www/html/nextcloud"/' /etc/httpd/conf/httpd.conf

Better sed. I removed the \s*

I think you can simplify it way more.

you don't need -e

don't use the / separator, use for instance #. So s#expression#replacement#. Then you don't have to escape your paths. And then you can put your variables straight in.

Don't think you need the sed script inside a quoted string either.

Maybe something like this:
sudo sed -i s#$^DocumentRoot$.*$#\1$WWW_PATH/$APP_FOLDER# /etc/httpd/conf/httpd.conf
If you want quotes around the sed "instructions" use " so you get variable expansion, and not '.
But you don't need to quote a string as long as it doesn't contain spaces.
I'll try it in a bit on my local test instance.

I'm in the middle of migrating the CentOS 7 system to the Fedora 32 system that caused me to write this in the first place.

Hmm, maybe you need some quotes anyway,

The sed thing is really s#regexp#\1 /www/whatever# (using `# as delimiter).
Where \1 tell sed to use the capture result of the first group which is "DocumentRoot".
Then a space and then the new path.

1337

@JaredBusch said in Setup Nextcloud 19.0.4 on Fedora 32:

Could not make it execute without the quotes
But this works.
sudo sed -i 's#$^DocumentRoot$.*$#\1 "'"$WWW_PATH"'/'"$APP_FOLDER"'"#' /etc/httpd/conf/httpd.conf

OK try this then:

sudo sed -i 's#\(^DocumentRoot\).*$#\1 '$WWW_PATH/$APP_FOLDER# /etc/httpd/conf/httpd.conf

JaredBusch

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

@JaredBusch said in Setup Nextcloud 19.0.4 on Fedora 32:
Could not make it execute without the quotes
But this works.
sudo sed -i 's#$^DocumentRoot$.*$#\1 "'"$WWW_PATH"'/'"$APP_FOLDER"'"#' /etc/httpd/conf/httpd.conf
OK try this then:
sudo sed -i 's#$^DocumentRoot$.*$#\1 '$WWW_PATH/$APP_FOLDER# /etc/httpd/conf/httpd.conf

That is missing the " that need to be around the value. But did make me realize I did not need to do all the quoting around the / since I changed the delimeter.. habits

sudo sed -i 's#\(^DocumentRoot\).*$#\1 "'$WWW_PATH/$APP_FOLDER'"#' /etc/httpd/conf/httpd.conf

JaredBusch

\"# also works to end it.

1337

@JaredBusch said in Setup Nextcloud 19.0.4 on Fedora 32:

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:
@JaredBusch said in Setup Nextcloud 19.0.4 on Fedora 32:
Could not make it execute without the quotes
But this works.
sudo sed -i 's#$^DocumentRoot$.*$#\1 "'"$WWW_PATH"'/'"$APP_FOLDER"'"#' /etc/httpd/conf/httpd.conf
OK try this then:
sudo sed -i 's#$^DocumentRoot$.*$#\1 '$WWW_PATH/$APP_FOLDER# /etc/httpd/conf/httpd.conf
That is missing the " that need to be around the value. But did make me realize I did not need to do all the quoting around the / since I changed the delimeter.. habits
sudo sed -i 's#$^DocumentRoot$.*$#\1 "'$WWW_PATH/$APP_FOLDER'"#' /etc/httpd/conf/httpd.conf

Starting to look pretty good I think.

I wonder about the ^DocumentRoot though. Apache don't need it to be the start of the line. There could be some whitespace first.

JaredBusch

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

I wonder about the ^DocumentRoot though. Apache don't need it to be the start of the line. There could be some whitespace first.

That is because there are 3 instances in the file. But only that one matters.

1337

@JaredBusch said in Setup Nextcloud 19.0.4 on Fedora 32:

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

I wonder about the ^DocumentRoot though. Apache don't need it to be the start of the line. There could be some whitespace first.

That is because there are 3 instances in the file. But only that one matters.

I understand I'm just thinking about whitespace. It's very common to have indentation in the conf files. Especially when you are putting it under virtualhost.

Then the regex wont match but works fine in apache.

JaredBusch

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

@JaredBusch said in Setup Nextcloud 19.0.4 on Fedora 32:

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

I wonder about the ^DocumentRoot though. Apache don't need it to be the start of the line. There could be some whitespace first.

That is because there are 3 instances in the file. But only that one matters.

I understand I'm just thinking about whitespace. It's very common to have indentation in the conf files. Especially when you are putting it under virtualhost.

This is not in a vhost. this is the main apache config file. Assumption is a single purpose server. anything else is advanced beyond this guide.

1337

@JaredBusch said in Setup Nextcloud 19.0.4 on Fedora 32:

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

@JaredBusch said in Setup Nextcloud 19.0.4 on Fedora 32:

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

I wonder about the ^DocumentRoot though. Apache don't need it to be the start of the line. There could be some whitespace first.

That is because there are 3 instances in the file. But only that one matters.

I understand I'm just thinking about whitespace. It's very common to have indentation in the conf files. Especially when you are putting it under virtualhost.

This is not in a vhost. this is the main apache config file. Assumption is a single purpose server. anything else is advanced beyond this guide.

Yeah, makes sense.

1337

@JaredBusch

sudo sed -i 's#(^DocumentRoot).*$#\1 "'$WWW_PATH/$APP_FOLDER'"#' /etc/httpd/conf/httpd.conf

I wonder if the capture group is actually worth it. You're just capturing the static "DocumentRoot".
~~It's much cleaner without it and less escaping and quoting.~~

sudo sed -i "s#^DocumentRoot.*$#DocumentRoot $WWW_PATH/$APP_FOLDER#" /etc/httpd/conf/httpd.conf

Never mind, not much of an improvement.

JaredBusch

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:

@JaredBusch

sudo sed -i 's#(^DocumentRoot).*$#\1 "'$WWW_PATH/$APP_FOLDER'"#' /etc/httpd/conf/httpd.conf

I wonder if the capture group is actually worth it. You're just capturing the static "DocumentRoot".
It's much cleaner without it and less escaping and quoting.
sudo sed -i "s#^DocumentRoot.*$#DocumentRoot $WWW_PATH/$APP_FOLDER#" /etc/httpd/conf/httpd.conf

and you are still missing the point that the default file has double quotes around it.
required or not, if it is the default format, I will keep it.

1337

@JaredBusch said in Setup Nextcloud 19.0.4 on Fedora 32:

@Pete-S said in Setup Nextcloud 19.0.4 on Fedora 32:
@JaredBusch

sudo sed -i 's#(^DocumentRoot).*$#\1 "'$WWW_PATH/$APP_FOLDER'"#' /etc/httpd/conf/httpd.conf

I wonder if the capture group is actually worth it. You're just capturing the static "DocumentRoot".
It's much cleaner without it and less escaping and quoting.
sudo sed -i "s#^DocumentRoot.*$#DocumentRoot $WWW_PATH/$APP_FOLDER#" /etc/httpd/conf/httpd.conf

Ah, it's the regexp.
OK, last chance:

sudo sed -i 's#^DocumentRoot.*$#DocumentRoot '$WWW_PATH/$APP_FOLDER# /etc/httpd/conf/httpd.conf